Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump abseil to latest version #7802

Merged
merged 1 commit into from
Aug 2, 2019
Merged

bump abseil to latest version #7802

merged 1 commit into from
Aug 2, 2019

Conversation

achasveachas
Copy link
Contributor

This fixes #7357 on windows Visual Studio 2017

Signed-off-by: Yechiel Kalmenson ykalmenson@pivotal.io
Signed-off-by: William Rowe wrowe@pivotal.io

Description:
This fixes the issue we saw with the constexpr absl::string_view constructor mentioned in #7357

Risk Level: Low

Testing: Confirmed this compiles on Windows

Docs Changes: N/A

Release Notes: N/A

[Optional Fixes #Issue] #7357

This fixes #7357 on windows Visual Studio 2017

Signed-off-by: William Rowe <wrowe@pivotal.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit b1fcf27 into envoyproxy:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows VS 2017 compiler complains about constexpr construct
2 participants