-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
egctl: only exec on running pod #1053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
arkodg
reviewed
Feb 17, 2023
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1053 +/- ##
==========================================
- Coverage 64.70% 64.59% -0.12%
==========================================
Files 67 67
Lines 8730 8730
==========================================
- Hits 5649 5639 -10
- Misses 2706 2714 +8
- Partials 375 377 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Feb 20, 2023
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
arkodg
reviewed
Feb 21, 2023
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
arkodg
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1052 #1054
cc @arkodg