Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egctl: only exec on running pod #1053

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Feb 17, 2023

fixes: #1052 #1054

cc @arkodg

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain marked this pull request as ready for review February 17, 2023 02:00
@zirain zirain requested a review from a team as a code owner February 17, 2023 02:00
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1053 (a4316a0) into main (c4d57fb) will decrease coverage by 0.12%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   64.70%   64.59%   -0.12%     
==========================================
  Files          67       67              
  Lines        8730     8730              
==========================================
- Hits         5649     5639      -10     
- Misses       2706     2714       +8     
- Partials      375      377       +2     
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 78.37% <0.00%> (-1.36%) ⬇️
internal/provider/kubernetes/controller.go 49.66% <0.00%> (-0.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain requested a review from arkodg February 21, 2023 03:34
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: zirain <hejianpeng2@huawei.com>
@zirain zirain requested a review from arkodg February 22, 2023 00:52
@arkodg arkodg merged commit 6ff1758 into envoyproxy:main Feb 22, 2023
@zirain zirain deleted the egctl-pod-status branch February 22, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

egctl version should not error out if server pod not present
3 participants