-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update config types doc #1348
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage 62.25% 62.25%
=======================================
Files 76 76
Lines 10837 10837
=======================================
Hits 6747 6747
Misses 3644 3644
Partials 446 446 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the fields (gateway
, provider
) be under a top level spec
field
let me investigate why it's changed |
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@arkodg the root cause is here:
|
Ah this is the startup config, so this style is fine |
What type of PR is this?
docs: update config types doc
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1247