Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update config types doc #1348

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 24, 2023

What type of PR is this?

docs: update config types doc

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1247

@zirain zirain requested a review from a team as a code owner April 24, 2023 11:07
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1348 (d29a914) into main (5c2d453) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1348   +/-   ##
=======================================
  Coverage   62.25%   62.25%           
=======================================
  Files          76       76           
  Lines       10837    10837           
=======================================
  Hits         6747     6747           
  Misses       3644     3644           
  Partials      446      446           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

arkodg
arkodg previously approved these changes Apr 24, 2023
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the fields (gateway, provider) be under a top level spec field

@arkodg arkodg self-requested a review April 24, 2023 17:17
@zirain
Copy link
Contributor Author

zirain commented Apr 25, 2023

let me investigate why it's changed

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
Copy link
Contributor Author

zirain commented Apr 25, 2023

@arkodg the root cause is here:

EnvoyGatewaySpec `json:",inline"`

@arkodg
Copy link
Contributor

arkodg commented Apr 25, 2023

Ah this is the startup config, so this style is fine

@Alice-Lilith Alice-Lilith merged commit edb56fe into envoyproxy:main Apr 25, 2023
@zirain zirain deleted the update-api-docs branch April 25, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make crd-ref-docs support gateway-api object
3 participants