Add validations for TLS Certs for a specific listener #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
+ Coverage 61.40% 61.66% +0.26%
==========================================
Files 79 79
Lines 11459 11490 +31
==========================================
+ Hits 7036 7085 +49
+ Misses 3962 3945 -17
+ Partials 461 460 -1
|
cnvergence
force-pushed
the
tls-validation
branch
2 times, most recently
from
47d1401
to
f075373
Compare
cnvergence
force-pushed
the
tls-validation
branch
from
f075373
to
13e6c41
Compare
arkodg
reviewed
May 22, 2023
arkodg
reviewed
May 22, 2023
|
the CI failure / conformance test failures seem to be legit |
cnvergence
force-pushed
the
tls-validation
branch
2 times, most recently
from
1ff177f
to
806c497
Compare
arkodg
reviewed
May 23, 2023
arkodg
reviewed
May 23, 2023
arkodg
reviewed
May 23, 2023
I need to fix this PR, it seems that the wildcard certificate is still breaking it https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/suite/suite.go#L158 |
arkodg
reviewed
May 24, 2023
cnvergence
force-pushed
the
tls-validation
branch
from
cecc6f2
to
abca6e2
Compare
arkodg
reviewed
May 26, 2023
arkodg
reviewed
May 26, 2023
|
added some minor comments, but this PR mostly looks good to me, thanks @cnvergence ! |
cnvergence
force-pushed
the
tls-validation
branch
2 times, most recently
from
670fe4d
to
688dc4b
Compare
LanceEa
reviewed
May 30, 2023
cnvergence
force-pushed
the
tls-validation
branch
from
da4fdf9
to
dd4c921
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
…n certificate Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
…hostname Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
tls-validation
branch
from
0ac0184
to
5ac2153
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
tls-validation
branch
from
5ac2153
to
b755169
Compare
arkodg
approved these changes
Jun 1, 2023
zirain
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1292