Make jwt fetch more reliable #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1784 +/- ##
==========================================
- Coverage 64.97% 64.95% -0.02%
==========================================
Files 84 84
Lines 12207 12209 +2
==========================================
- Hits 7931 7930 -1
- Misses 3770 3773 +3
Partials 506 506
|
|
probably blocked on #1601 which fixes some issues in the conformance tests in the newer v0.8.0-rc1 version that was recently added |
Async is useful because it will not block requests with jwt fetches, will not need to jwt fetch per thread Retrying once after a failed fetch is also useful Signed-off-by: Jack Kleeman <jackkleeman@gmail.com>
jackkleeman
force-pushed
the
async-jwt-fetch
branch
from
ceaeac4
to
a2066a9
Compare
|
i cant merge: please go ahead |
zirain
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async is useful because it will not block requests with jwt fetches, will not need to jwt fetch per thread Retrying once after a failed fetch is also useful