fix: Remove ErrHTTPRouteMatchEmpty check for Xds IR #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty matches are supported in the gateway api spec e.g. https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1alpha2.GRPCRouteRule and we are also tranlating it correctly in the gateway-api layer e.g. https://github.com/envoyproxy/gateway/blob/76704d1124eccaf06b81634a96390c95722a0554/internal/gatewayapi/route.go#L212 but the IR layer is rejecting this valid config Relates to envoyproxy#1958 (comment) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
requested review from
a team,
LanceEa,
chauhanshubham and
Xunzhuo
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1959 +/- ##
==========================================
- Coverage 65.43% 65.36% -0.08%
==========================================
Files 90 90
Lines 13367 13364 -3
==========================================
- Hits 8747 8735 -12
- Misses 4083 4090 +7
- Partials 537 539 +2
|
zirain
approved these changes
Oct 13, 2023
zhaohuabing
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty matches are supported in the gateway api spec e.g. https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1alpha2.GRPCRouteRule and we are also tranlating it correctly in the gateway-api layer e.g.
gateway/internal/gatewayapi/route.go
Line 212 in 76704d1
Relates to #1958 (comment)