Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: http to https redirect user guide #2167

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

ionutvilie
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Adds HTTP to HTTPS redirect user guide using the sectionName field

Which issue(s) this PR fixes:

Fixes #2159

@ionutvilie ionutvilie requested a review from a team as a code owner November 8, 2023 16:51
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2167 (d53718e) into main (a0505b9) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2167      +/-   ##
==========================================
- Coverage   64.30%   64.26%   -0.05%     
==========================================
  Files         107      107              
  Lines       14665    14665              
==========================================
- Hits         9431     9424       -7     
- Misses       4667     4673       +6     
- Partials      567      568       +1     

see 2 files with indirect coverage changes

@arkodg
Copy link
Contributor

arkodg commented Nov 10, 2023

hey @ionutvilie this looks good ! DCO is failing, can you sign and push again ?

Signed-off-by: Ionut Ilie <ionutvilie@gmail.com>
Signed-off-by: Ionut Ilie <ionutvilie@gmail.com>
@ionutvilie
Copy link
Contributor Author

@arkodg i think, i managed to fix it.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, kflynn, tmsnan and shawnh2 and removed request for a team November 13, 2023 18:35
@zirain zirain merged commit 0cf4f28 into envoyproxy:main Nov 13, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question regarding HTTPS listeners
3 participants