Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for CORS #2169

Merged
merged 1 commit into from
Nov 10, 2023
Merged

test: add e2e test for CORS #2169

merged 1 commit into from
Nov 10, 2023

Conversation

ardikabs
Copy link
Contributor

@ardikabs ardikabs commented Nov 9, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2139

@ardikabs ardikabs requested a review from a team as a code owner November 9, 2023 13:20
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2169 (a95eb91) into main (ad38383) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
- Coverage   64.29%   64.27%   -0.02%     
==========================================
  Files         107      107              
  Lines       14671    14671              
==========================================
- Hits         9432     9430       -2     
- Misses       4671     4673       +2     
  Partials      568      568              

see 1 file with indirect coverage changes

test/e2e/tests/cors.go Outdated Show resolved Hide resolved
Signed-off-by: Ardika Bagus <me@ardikabs.com>
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ardikabs

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg merged commit 3b12946 into envoyproxy:main Nov 10, 2023
18 checks passed
@ardikabs ardikabs deleted the e2e/cors branch November 10, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: add test for CORS
3 participants