Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in bootstrap example #2171

Merged
merged 1 commit into from
Nov 10, 2023
Merged

docs: fix typo in bootstrap example #2171

merged 1 commit into from
Nov 10, 2023

Conversation

akhenakh
Copy link
Contributor

@akhenakh akhenakh commented Nov 9, 2023

The example to customize the bootstrap config is wrong and leads to an error:

cat eg.yaml| egctl x translate --from gateway-api --to xds  -f - 
Error: proto: syntax error (line 1:10): unexpected token [
proto: syntax error (line 1:10): unexpected token [

@akhenakh akhenakh requested a review from a team as a code owner November 9, 2023 21:32
zirain
zirain previously approved these changes Nov 9, 2023
arkodg
arkodg previously approved these changes Nov 10, 2023
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this !

@arkodg
Copy link
Contributor

arkodg commented Nov 10, 2023

@akhenakh seeing a conflict, can you rebase and push ?

Signed-off-by: Fabrice Aneche <akhenakh@users.noreply.github.com>
@akhenakh
Copy link
Contributor Author

@akhenakh seeing a conflict, can you rebase and push ?

done

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2171 (c1a891a) into main (ad38383) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2171   +/-   ##
=======================================
  Coverage   64.29%   64.29%           
=======================================
  Files         107      107           
  Lines       14671    14671           
=======================================
+ Hits         9432     9433    +1     
  Misses       4671     4671           
+ Partials      568      567    -1     

see 2 files with indirect coverage changes

@arkodg arkodg merged commit c7f9e22 into envoyproxy:main Nov 10, 2023
18 checks passed
@akhenakh
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants