Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xds translation return early, should be done in a best-effort manner #2202

Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix: xds translation return early, should be done in a best-effort manner #2202

merged 3 commits into from
Nov 20, 2023

Conversation

zhaohuabing
Copy link
Member

fix: #2200

@zhaohuabing zhaohuabing requested a review from a team as a code owner November 17, 2023 22:33
@zhaohuabing zhaohuabing marked this pull request as draft November 17, 2023 22:33
@zhaohuabing zhaohuabing force-pushed the fix-early-return branch 2 times, most recently from 7fd051c to 58226e4 Compare November 17, 2023 23:27
@zhaohuabing
fix: xds translation return early, should be done in a best-effort wa…
94a1854 
…y instead

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
add test for partial invalid resources
e96e32d 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
fix test
398a6d9 
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review November 18, 2023 03:30
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (1789d98) 64.20% compared to head (398a6d9) 64.37%.

Files Patch % Lines
internal/xds/translator/translator.go 70.65% 24 Missing and 3 partials ⚠️
internal/xds/translator/runner/runner.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
+ Coverage   64.20%   64.37%   +0.16%     
==========================================
  Files         109      109              
  Lines       15266    15302      +36     
==========================================
+ Hits         9801     9850      +49     
+ Misses       4851     4843       -8     
+ Partials      614      609       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing changed the title fix: xds translation return early, should be done in a best-effort way fix: xds translation return early, should be done in a best-effort manner Nov 18, 2023
@zhaohuabing zhaohuabing mentioned this pull request Nov 19, 2023
Merged
Xunzhuo
Xunzhuo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for improving it

@Xunzhuo Xunzhuo merged commit c7b1756 into envoyproxy:main Nov 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: XDS generation should be done in a best-effort way instead of returning early.
3 participants
@zhaohuabing @zirain @Xunzhuo