refactor errors and xds for BackendTrafficPolicy and SecurityPolicy

[shawnh2]

What type of PR is this?

What this PR does / why we need it:

• reuse the translated logic, currently there're a lot of dup code in translateXXXPolicyForRoute and translateXXXPolicyForGateway for BTP and SP, this PR extract the common part of these two methods into one shared method
• group BTP and SP features in xds.go into a struct, so we can perform Any() and Validate(), make the code structure more clean
• wrap the build error in translate method with its feature's name via perr.WrapWithMessage() for SP and BTP, providing more context about errors
• for BTP, change errors directly return behavior to errors join

Which issue(s) this PR fixes:

Fixes #2894
Fixes #2954

[codecov]

Codecov Report

Attention: Patch coverage is 59.75610% with 165 lines in your changes are missing coverage. Please review.

Project coverage is 64.37%. Comparing base (6a57cd1) to head (d92fc4d).

Files	Patch %	Lines
internal/ir/zz_generated.deepcopy.go	0.00%	92 Missing and 2 partials ⚠️
internal/ir/xds.go	12.28%	46 Missing and 4 partials ⚠️
internal/gatewayapi/backendtrafficpolicy.go	87.36%	8 Missing and 4 partials ⚠️
internal/gatewayapi/securitypolicy.go	88.57%	3 Missing and 1 partial ⚠️
internal/xds/translator/oidc.go	70.00%	1 Missing and 2 partials ⚠️
internal/gatewayapi/route.go	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2926      +/-   ##
==========================================
- Coverage   64.60%   64.37%   -0.23%     
==========================================
  Files         122      122              
  Lines       21147    21161      +14     
==========================================
- Hits        13662    13623      -39     
- Misses       6637     6707      +70     
+ Partials      848      831      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shawnh2]

this part is reverted from https://github.com/envoyproxy/gateway/pull/2846/files#diff-ce86bc9474dbc964bb6180e6a110b708dd85081193dca54a2fa7cda70d742247L930, since BTP has supported dealing with multi-errors now

[zirain]

/retest

[shawnh2]

/retest

[zhaohuabing]

This PR contains many files, It would be easier to review if you could list the changes in the description.

[shawnh2]

This PR contains many files, It would be easier to review if you could list the changes in the description.

Sure thing

[zhaohuabing]

@shawnh2

Thank you for tidying up the code!

This PR is in a good direction, however, I found it a bit difficult for me to review when going through it line by line. Would you mind splitting this PR into three as the following?

1. reuse the translated logic, currently there're a lot of dup code in translateXXXPolicyForRoute and translateXXXPolicyForGateway for BTP and SP, this PR extract the common part of these two methods into one shared method

2. group BTP and SP features in xds.go into a struct, so we can perform Any() and Validate(), make the code structure more clean

3. wrap the build error in translate method with its feature's name via perr.WrapWithMessage() for SP and BTP, providing more context about errors
   for BTP, change errors directly return behavior to errors join

[shawnh2]

@shawnh2

Thank you for tidying up the code!

This PR is in a good direction, however, I found it a bit difficult for me to review when going through it line by line. Would you mind splitting this PR into three as the following?

1. reuse the translated logic, currently there're a lot of dup code in translateXXXPolicyForRoute and translateXXXPolicyForGateway for BTP and SP, this PR extract the common part of these two methods into one shared method

2. group BTP and SP features in xds.go into a struct, so we can perform Any() and Validate(), make the code structure more clean

3. wrap the build error in translate method with its feature's name via perr.WrapWithMessage() for SP and BTP, providing more context about errors

for BTP, change errors directly return behavior to errors join

Of course, thanks for reviewing this, I will split it up to serval PRs