feat(translator): Implement consistent hash table size in BackendTrafficPolicy #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
shawnh2
reviewed
May 20, 2024
...i/testdata/backendtrafficpolicy-with-loadbalancer-invalid-consistent-hash-table-size.in.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3440 +/- ##
==========================================
+ Coverage 67.09% 67.12% +0.02%
==========================================
Files 166 166
Lines 19618 19632 +14
==========================================
+ Hits 13163 13178 +15
+ Misses 5504 5501 -3
- Partials 951 953 +2 ☔ View full report in Codecov by Sentry. |
|
LGTM! #3302 has introduced a new error processing way for BTP, can you update the code, then we are good to go! |
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
|
/retest |
|
/retest |
1 similar comment
|
/retest |
arkodg
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement consistent hash table size in BackendTrafficPolicy, follow up #3348
Which issue(s) this PR fixes:
Fixes #3272