fix: EEP RG enforcement #3475
Merged
fix: EEP RG enforcement #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
approved these changes
May 24, 2024
arkodg
approved these changes
May 25, 2024
|
can you run |
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
fix-eep-referencegrant
branch
from
1222c31
to
077a2b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 166 166
Lines 19720 19722 +2
=======================================
+ Hits 13257 13259 +2
Misses 5507 5507
Partials 956 956 ☔ View full report in Codecov by Sentry. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix validation of policy backend references to consider all policy types. Fix reference grants in test accordingly.