Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: direct response #4334

Merged
merged 4 commits into from
Oct 18, 2024
Merged

api: direct response #4334

merged 4 commits into from
Oct 18, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Sep 26, 2024

Relates to #2714

@arkodg arkodg requested a review from a team as a code owner September 26, 2024 02:01
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (70c7c34) to head (885d0a8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4334      +/-   ##
==========================================
- Coverage   65.82%   65.59%   -0.23%     
==========================================
  Files         200      200              
  Lines       24278    30268    +5990     
==========================================
+ Hits        15980    19854    +3874     
- Misses       7158     9274    +2116     
  Partials     1140     1140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xunzhuo
Xunzhuo previously approved these changes Sep 29, 2024
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us get this in

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates to envoyproxy#2714

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
zirain previously approved these changes Oct 18, 2024
zhaohuabing
zhaohuabing previously approved these changes Oct 18, 2024
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg dismissed stale reviews from zhaohuabing and zirain via 885d0a8 October 18, 2024 00:39
@arkodg arkodg requested review from zhaohuabing, zirain and a team October 18, 2024 00:39
@arkodg arkodg merged commit 5375cf0 into envoyproxy:main Oct 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants