Translate RateLimitInfra into K8s resources #939
Conversation
Relates to envoyproxy#670 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #939 +/- ##
==========================================
- Coverage 63.84% 61.51% -2.34%
==========================================
Files 54 54
Lines 7834 8140 +306
==========================================
+ Hits 5002 5007 +5
- Misses 2519 2818 +299
- Partials 313 315 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| // rateLimitInfraHTTPPort is the http port that the rate limit service listens on. | ||
| rateLimitInfraHTTPPort = 8080 | ||
| // rateLimitInfraImage is the container image for the rate limit service. | ||
| rateLimitInfraImage = "envoyproxy/ratelimit:latest" |
There was a problem hiding this comment.
TODO: make this configurable in EnvoyGateway.RateLimit
There was a problem hiding this comment.
sure, rather than add a TODO comment in code, should be raised as a GH issue explaining the use cases where this is needed
| Name: svc.Name, | ||
| } | ||
|
|
||
| if err := i.Client.Get(ctx, key, current); err != nil { |
There was a problem hiding this comment.
can we make L180-L197 reusable?
There was a problem hiding this comment.
looks like we'd move the complexity over to the util func - we could pass objects asClient.Object to it, which is fine, but we also do an equality check on obj.Spec, so we'd have to typecast it back to the orig obj type
There was a problem hiding this comment.
address and refactor this later
Relates to #670
Signed-off-by: Arko Dasgupta arko@tetrate.io