Merge Master and AsyncUDP in one branch #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Master and AsyncUDP in one branch In the esp-knx-ip.h file can be selected to use the UDP library - WIFIUDP (for esp8266 lib v2.3.0 and up) - AsyncUDP (for esp8266 lib v2.4.1 and up)
|
Hi Nico, How are you? In this PR, I propose to merge both branches and add a new key in the esp-knx-ip.h file to select which Multicast Library to use, due to the problems on the esp8266 board libraries. This is the version of esp-knx-ip library that is being used in Sonoff-Tasmota for KNX communication, so the user has the choice of using v2.4.1 and ESPasyncUDP or 2.3.0 and WIFIUDP. Hope you consider it. Thanks! |
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Master and AsyncUDP in one branch
In the esp-knx-ip.h file you can select which UDP library to use: