Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENYO-2505: Persistent item’s incomplete swipe action is completed on a subsequent swipe #70

Merged
merged 1 commit into from
Dec 17, 2013

Conversation

aarontam
Copy link
Contributor

Issue

For persistent swipeable items, an incomplete swipe will be completed on a subsequent swipe (i.e. swipe and drag to scroll). This is caused by the persistentItemVisible flag being set to true regardless of the swipe completion status.

Fix

The persistentItemVisible flag is now only set if the swipe is complete. The choice to make a change here, as opposed to calling setPersistSwipeableItem(false) in the backOutSwipe method, is that this change is agnostic to how persistent items are implemented (currently setPersistSwipeableItem(true) needs to be called for each item via the setupSwipeItem handler). For example, if the implementation were to change such that the persistSwipeableItem flag on the List was not treated as temporary, then setPersistSwipeableItem(false) in backOutSwipe would eat this value.

Enyo-DCO-1.1-Signed-off-by: Aaron Tam aaron.tam@lge.com

…n a subsequent swipe, even if the original swipe was never completed.

Enyo-DCO-1.1-Signed-off-by: Aaron Tam <aaron.tam@lge.com>
@aarontam
Copy link
Contributor Author

Alternatively, we can wait until there is a rewrite of the List code, which will likely address the original issue if the logic for persistent items is re-examined.

unwiredben added a commit that referenced this pull request Dec 17, 2013
ENYO-2505: Persistent item’s incomplete swipe action is completed on a subsequent swipe

Reviewed-By: Ben Combee (ben.combee@lge.com)
@unwiredben unwiredben merged commit 564448f into master Dec 17, 2013
@unwiredben unwiredben deleted the ENYO-2505 branch December 17, 2013 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants