ENYO-2505: Persistent item’s incomplete swipe action is completed on a subsequent swipe #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For persistent swipeable items, an incomplete swipe will be completed on a subsequent swipe (i.e. swipe and drag to scroll). This is caused by the
persistentItemVisible
flag being set totrue
regardless of the swipe completion status.Fix
The
persistentItemVisible
flag is now only set if the swipe is complete. The choice to make a change here, as opposed to callingsetPersistSwipeableItem(false)
in thebackOutSwipe
method, is that this change is agnostic to how persistent items are implemented (currentlysetPersistSwipeableItem(true)
needs to be called for each item via thesetupSwipeItem
handler). For example, if the implementation were to change such that thepersistSwipeableItem
flag on theList
was not treated as temporary, thensetPersistSwipeableItem(false)
inbackOutSwipe
would eat this value.Enyo-DCO-1.1-Signed-off-by: Aaron Tam aaron.tam@lge.com