-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FetchMaxBytes #321
FetchMaxBytes #321
Conversation
@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
============================================
+ Coverage 96.06% 96.10% +0.03%
- Complexity 111 112 +1
============================================
Files 55 56 +1
Lines 229 231 +2
============================================
+ Hits 220 222 +2
Misses 9 9
☔ View full report in Codecov by Sentry. |
@rultor merge |
@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 2min) |
@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
closes #319
PR-Codex overview
This PR adds a new class
FetchMaxBytes
to wrap thefetch.max.bytes
Kafka attribute. It also includes a test case for this new class.Detailed summary
FetchMaxBytes
class to wrapfetch.max.bytes
Kafka attributeFetchMaxBytes
class