Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchMaxBytes #321

Merged
merged 1 commit into from
May 13, 2023
Merged

FetchMaxBytes #321

merged 1 commit into from
May 13, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented May 13, 2023

closes #319


PR-Codex overview

This PR adds a new class FetchMaxBytes to wrap the fetch.max.bytes Kafka attribute. It also includes a test case for this new class.

Detailed summary

  • Added FetchMaxBytes class to wrap fetch.max.bytes Kafka attribute
  • Added test case for FetchMaxBytes class

The following files were skipped due to too many changes: README.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented May 13, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (3669ff2) 96.06% compared to head (89e36d6) 96.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #321      +/-   ##
============================================
+ Coverage     96.06%   96.10%   +0.03%     
- Complexity      111      112       +1     
============================================
  Files            55       56       +1     
  Lines           229      231       +2     
============================================
+ Hits            220      222       +2     
  Misses            9        9              
Impacted Files Coverage Δ
.../github/eocqrs/kafka/parameters/FetchMaxBytes.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h1alexbel
Copy link
Member Author

@rultor merge

@zoeself
Copy link
Collaborator

zoeself commented May 13, 2023

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-05-16T08:22:16.377573.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@rultor
Copy link
Collaborator

rultor commented May 13, 2023

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 89e36d6 into master May 13, 2023
@rultor
Copy link
Collaborator

rultor commented May 13, 2023

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@h1alexbel h1alexbel deleted the 319 branch May 13, 2023 08:38
@zoeself
Copy link
Collaborator

zoeself commented May 13, 2023

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer fetch.max.bytes
4 participants