Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadocs ref. #337

Merged
merged 1 commit into from
May 24, 2023
Merged

javadocs ref. #337

merged 1 commit into from
May 24, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented May 24, 2023

closes #80


PR-Codex overview

This PR adds a new badge to the README file and updates an existing one.

Detailed summary

  • Added a javadoc badge to the README file.
  • Updated the codecov badge to use a new token.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented May 24, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (934481f) 96.27% compared to head (9091788) 96.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #337   +/-   ##
=========================================
  Coverage     96.27%   96.27%           
  Complexity      126      126           
=========================================
  Files            61       61           
  Lines           295      295           
=========================================
  Hits            284      284           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zoeself
Copy link
Collaborator

zoeself commented May 24, 2023

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-05-27T10:22:21.598416.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member Author

@rultor merge

@h1alexbel
Copy link
Member Author

@zoeself deregister

@zoeself
Copy link
Collaborator

zoeself commented May 24, 2023

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

@rultor
Copy link
Collaborator

rultor commented May 24, 2023

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9091788 into master May 24, 2023
@rultor
Copy link
Collaborator

rultor commented May 24, 2023

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javadocs automated publishing
4 participants