-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cached messages #429
cached messages #429
Conversation
@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
=========================================
Coverage 99.00% 99.00%
Complexity 173 173
=========================================
Files 82 82
Lines 504 504
Branches 1 1
=========================================
Hits 499 499
Misses 5 5
☔ View full report in Codecov by Sentry. |
@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
@l3r8yJ can we introduce any tests on this? |
@h1alexbel I'll create a puzzle |
@h1alexbel take a look, please |
@h1alexbel Don't forget to close this ticket before the deadline (2023-08-23T17:59:10). You are past the first half of the allowed period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ Overall looks good, but also, I have a few questions
@@ -55,7 +64,7 @@ public WithPartition( | |||
final Message<K, X> msg | |||
) { | |||
this.partition = prtn; | |||
this.message = msg; | |||
this.message = new Synced<>(new Sticky<>(msg)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ why we are doing Sync here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel Due to the fact that Sticky
is not thread-safe by default
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 2min) |
@l3r8yJ thanks |
@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
closes #428
@h1alexbel take a look, please
PR-Codex overview
This PR focuses on improving the caching mechanism in the
Timestamped
andWithPartition
classes.Detailed summary
Scalar
,Sticky
, andSynced
message
field inTimestamped
andWithPartition
toScalar<ProducerRecord<K, X>>
Timestamped
andWithPartition
to useSynced
andSticky
for caching