Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify bounding box for cards #10

Closed
BudgieInWA opened this issue Dec 4, 2018 · 4 comments
Closed

Allow user to specify bounding box for cards #10

BudgieInWA opened this issue Dec 4, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@BudgieInWA
Copy link
Contributor

The new dragging feature could be improved to provide a fully user-configurable way of working. Instead of having a drag handle that is always visible, have a "configure" button that switches to "configure mode". While in configure mode, draw a box around the border of the windows and provide handles in the corners. Ask the user to position the box so that all of the cards are inside the box and the banner is above them. Then the detection algorithm can find the exact edges.

The top left handle could act like the drag currently does, and the bottom right handle could scale the rectangle, maintaining the aspect ratio.
image

This method should work for any configuration that cannot be predicted (like running in a small window) so it might be useful to have, even if all of the common configurations work out of the box.

@BudgieInWA
Copy link
Contributor Author

BudgieInWA commented Dec 4, 2018

In fact, I'm basically thinking of Snipping Tool.

When the overlay opens it guesses where the cards are (assuming fullscreen borderless and whatever dimensions the game is known to use). By clicking a "locate" button or any time a scan is done and no cards are found, it could immediately switch to "rectangular snip" mode with instructions "Select the Cards" and a cancel button. The dimensions of the rectangle can be used to check for cards in the screenshot and to decide where to put the banner.

If the user failed to draw around the cards properly they could see a gif of someone doing it correctly.

@eoakley
Copy link
Owner

eoakley commented Dec 4, 2018

Nice suggestion. Implementing it soon.

@eoakley
Copy link
Owner

eoakley commented Dec 4, 2018

Made the border detection algorithm more robust. Should not need to implement custom bounding boxes yet.

@eoakley eoakley added the enhancement New feature or request label Dec 4, 2018
@eoakley
Copy link
Owner

eoakley commented Dec 5, 2018

Just fixed this in the latest release.

Try the new function "Customize Grid".

If you still have problems, open a new issue with the following:

  • Description of your setup (monitor resolutions)
  • Full screenshot (all monitors)
  • File screenshot_debugg.png from the install dir
  • File Artifact_Helper.launch.pyw.log from the folder C:\Users<your_user>\AppData\Roaming

Thanks for the help!

@eoakley eoakley closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants