Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature:spec] Implement all tests + Remove version number #40

Merged
merged 19 commits into from
Apr 8, 2019
Merged

[feature:spec] Implement all tests + Remove version number #40

merged 19 commits into from
Apr 8, 2019

Conversation

eonu
Copy link
Owner

@eonu eonu commented Apr 8, 2019

  • Implement all tests.
  • Remove version number from Paper#id and Paper#url.
  • Add Paper#version for the paper's version number.
  • Redefine Paper#revision? to use Paper#version.
  • Add Cleaner.extract_id and Cleaner.extract_version.
  • Make Query#add_connective always return self.
  • Redefine Arx.search to user Paper.parse's search key-word argument.

eonu added 19 commits April 4, 2019 19:40
@eonu eonu changed the title [feature:specs] Implement all tests + Remove version number [feature:spec] Implement all tests + Remove version number Apr 8, 2019
@eonu eonu merged commit 64a3b97 into master Apr 8, 2019
@eonu eonu mentioned this pull request Apr 8, 2019
Merged
@eonu eonu deleted the feature/specs branch April 8, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eonu