Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch:spec] Update spec paper 1710.02185 (revision + accepted by journal) #76

Merged
merged 2 commits into from
Nov 28, 2019
Merged

[patch:spec] Update spec paper 1710.02185 (revision + accepted by journal) #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf3ed5
Update spec paper 1710.02185 (accepted by journal)
eonu Nov 28, 2019
e38ba4f
Merge branch 'master' of https://github.com/eonu/arx into spec/update…
eonu Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions spec/arx/entities/paper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
it { expect(papers[1].id true).to eq '1105.5379v1' }
end
context '1710.02185' do
it { expect(papers[2].id true).to eq '1710.02185v3' }
it { expect(papers[2].id true).to eq '1710.02185v4' }
end
context '1703.04834' do
it { expect(papers[3].id true).to eq '1703.04834v1' }
Expand Down Expand Up @@ -60,7 +60,7 @@
it { expect(papers[1].url true).to eq 'http://arxiv.org/abs/1105.5379v1' }
end
context '1710.02185' do
it { expect(papers[2].url true).to eq 'http://arxiv.org/abs/1710.02185v3' }
it { expect(papers[2].url true).to eq 'http://arxiv.org/abs/1710.02185v4' }
end
context '1703.04834' do
it { expect(papers[3].url true).to eq 'http://arxiv.org/abs/1703.04834v1' }
Expand All @@ -75,7 +75,7 @@
it { expect(papers[1].version).to eq 1 }
end
context '1710.02185' do
it { expect(papers[2].version).to eq 3 }
it { expect(papers[2].version).to eq 4 }
end
context '1703.04834' do
it { expect(papers[3].version).to eq 1 }
Expand Down Expand Up @@ -259,7 +259,7 @@
subject { papers[2].updated_at }

it { is_expected.to be_a DateTime }
it { expect(subject.to_s).to eq '2017-11-07T22:45:22+00:00' }
it { expect(subject.to_s).to eq '2019-10-08T13:29:33+00:00' }
end
context '1703.04834' do
subject { papers[3].updated_at }
Expand Down Expand Up @@ -304,7 +304,7 @@
it { expect { papers[1].comment }.to raise_error Error::MissingField }
end
context '1710.02185' do
it { expect(papers[2].comment).to eq '31 pages, 17 figures; corrected author list' }
it { expect(papers[2].comment).to eq '27 pages, 13 figures, published version' }
end
context '1703.04834' do
it { expect { papers[3].comment }.to raise_error Error::MissingField }
Expand All @@ -318,7 +318,7 @@
it { expect(papers[1].journal?).to be true }
end
context '1710.02185' do
it { expect(papers[2].journal?).to be false }
it { expect(papers[2].journal?).to be true }
end
context '1703.04834' do
it { expect(papers[3].journal?).to be false }
Expand All @@ -332,7 +332,7 @@
it { expect(papers[1].journal).to eq 'In the 28th International Conference on Machine Learning, July 2011, Washington, USA' }
end
context '1710.02185' do
it { expect { papers[2].journal }.to raise_error Error::MissingField }
it { expect(papers[2].journal).to eq 'Class. Quantum Grav. 35 065010 (2018)' }
end
context '1703.04834' do
it { expect { papers[3].journal }.to raise_error Error::MissingField }
Expand Down Expand Up @@ -360,7 +360,7 @@
it { expect(papers[1].pdf_url).to eq 'http://arxiv.org/pdf/1105.5379v1' }
end
context '1710.02185' do
it { expect(papers[2].pdf_url).to eq 'http://arxiv.org/pdf/1710.02185v3' }
it { expect(papers[2].pdf_url).to eq 'http://arxiv.org/pdf/1710.02185v4' }
end
context '1703.04834' do
it { expect(papers[3].pdf_url).to eq 'http://arxiv.org/pdf/1703.04834v1' }
Expand Down