Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support *args and **kwargs #108

Merged
merged 3 commits into from
Dec 22, 2023
Merged

feat: support *args and **kwargs #108

merged 3 commits into from
Dec 22, 2023

Conversation

eonu
Copy link
Owner

@eonu eonu commented Dec 22, 2023

  • *args is fully supported.
  • **kwargs are ignored, as there is no easy way for a Click command to accept arbitrary options without having to individually call click.option for each one (which is impossible as this information is not known at compile time).

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build b4329f66-90c2-43e9-aaf0-c88066cdf8af

  • 31 of 31 (100.0%) changed or added relevant lines in 3 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.6%) to 96.987%

Files with Coverage Reduction New Missed Lines %
core/command.py 2 87.95%
_internal/_decorators.py 4 90.24%
feud/core/command.py 9 92.62%
Totals Coverage Status
Change from base Build 725116c6-f18c-4b53-ba63-37961f826ea3: -0.6%
Covered Lines: 1738
Relevant Lines: 1792

💛 - Coveralls

@eonu eonu merged commit 47ac5d9 into dev Dec 22, 2023
9 checks passed
@eonu eonu deleted the support-var-args-kwargs branch December 22, 2023 03:34
This was referenced Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants