Freeze #75
Merged
Freeze #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animatory
reviewed
Aug 2, 2022
torchok/constructor/runner.py
Outdated
| # Create callbacks | ||
| callbacks_config = train_config.callbacks | ||
| if callbacks_config is not None and len(callbacks_config) != 0: | ||
| callbacks = callbacks if callbacks is not None else [] |
There was a problem hiding this comment.
callbacks = callbacks or None
Animatory
reviewed
Aug 2, 2022
torchok/callbacks/freeze_unfreeze.py
Outdated
| """ | ||
| # Get all module names from self._epoch2module_names | ||
| freeze_module_names = [] | ||
| for _, module_names in self._epoch2module_names.items(): |
There was a problem hiding this comment.
for module_names in self._epoch2module_names.values():
Animatory
reviewed
Aug 2, 2022
torchok/callbacks/freeze_unfreeze.py
Outdated
| def freeze_before_training(self, pl_module: nn.Module): | ||
| """Freeze modules befor training. | ||
|
|
||
| Freeze all the modules which names in self._epoch2module_names. |
There was a problem hiding this comment.
Freeze all the modules named in self._epoch2module_names.
Animatory
reviewed
Aug 2, 2022
torchok/callbacks/freeze_unfreeze.py
Outdated
| """Init FreezeUnfreeze. | ||
|
|
||
| Args: | ||
| epoch2module_names: Dictionary for incremental unfreeze. Keys - epoch for unfreeze, values - module names |
There was a problem hiding this comment.
epoch2module_names: Incremental unfreeze dictionary. Keys - unfreeze epoch, values - module names to unfreeze. By default, all the modules named in this dictionary will be frozen before training
Animatory
reviewed
Aug 2, 2022
torchok/callbacks/freeze_unfreeze.py
Outdated
|
|
||
| not_found_modules = module_names - found_module_names | ||
| if len(not_found_modules) != 0: | ||
| logging.warning(f'Get modules_by_names function, can`t found modules with names = {not_found_modules}') |
There was a problem hiding this comment.
get_modules_by_names function can`t find modules with names {not_found_modules}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.