Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walletconnect support #69

Merged
merged 13 commits into from
Nov 8, 2023
Merged

Add walletconnect support #69

merged 13 commits into from
Nov 8, 2023

Conversation

yarkinwho
Copy link
Contributor

No description provided.

@yarkinwho yarkinwho marked this pull request as draft October 24, 2023 02:02
@yarkinwho yarkinwho self-assigned this Oct 24, 2023
@yarkinwho
Copy link
Contributor Author

yarkinwho commented Oct 30, 2023

Also includes fixes for minor translation issues discovered.
Including #67

@yarkinwho yarkinwho marked this pull request as ready for review October 30, 2023 03:06
Copy link
Member

@stephenpdeos stephenpdeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few link updates and translation updates

src/i18n.js Outdated
'footer.copyright': '© 2023 EOS Network Foundation all rights reserved.',

'app.walletconnect.failedswitch.title': 'Missing Network Configuration in Wallet',
'app.walletconnect.failedswitch.content': `<p>We've detected that the wallet you are attempting to use has not been configured to support EOS EVM yet. Please use the following network information to add the network or visit our <a href="https://docs.eosnetwork.com/evm/quick-start/introduction" >documentation</a> page for more details.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to open in new tab and use the following link for EN "https://docs.eosnetwork.com/evm/quick-start/setup-metamask"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/i18n.js Outdated
'footer.copyright': '© 2023 EOS 네트워크 재단 판권 소유.',

'app.walletconnect.failedswitch.title': '지갑에 네트워크 구성이 누락되었습니다',
'app.walletconnect.failedswitch.content': `<p>귀하가 사용하려는 지갑이 아직 EOS EVM을 지원하지 않은 것으로 확인되었습니다. 다음 네트워크 정보를 이용하여 네트워크를 추가하거나 <a href="https://docs.eosnetwork.com/evm/quick-start/introduction" >문서 페이지</a> 를 방문하여 자세한 내용을 확인해 보시기 바랍니다.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/i18n.js Outdated
'footer.copyright': '© 2023 EOS 网络基金会保留所有权利。',

'app.walletconnect.failedswitch.title': '钱包中缺失网络配置',
'app.walletconnect.failedswitch.content': `<p>我们检测到您尝试使用的钱包尚未配置以支持EOS EVM。请使用以下网络信息添加网络,或访问我们的<a href="https://docs.eosnetwork.com/evm/quick-start/introduction" >文档页面</a>获取更多详细信息。</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/i18n.js Outdated

'app.walletconnect.failedswitch.title': '钱包中缺失网络配置',
'app.walletconnect.failedswitch.content': `<p>我们检测到您尝试使用的钱包尚未配置以支持EOS EVM。请使用以下网络信息添加网络,或访问我们的<a href="https://docs.eosnetwork.com/evm/quick-start/introduction" >文档页面</a>获取更多详细信息。</p>
<details><summary><b>Mainnet</b></summary><p dir="auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主网

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/i18n.js Outdated
</ul>
<p dir="auto"></p></details>

<details><summary><b>Testnet</b></summary><p dir="auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试网

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/i18n.js Outdated

'app.walletconnect.failedswitch.title': '지갑에 네트워크 구성이 누락되었습니다',
'app.walletconnect.failedswitch.content': `<p>귀하가 사용하려는 지갑이 아직 EOS EVM을 지원하지 않은 것으로 확인되었습니다. 다음 네트워크 정보를 이용하여 네트워크를 추가하거나 <a href="https://docs.eosnetwork.com/evm/quick-start/introduction" >문서 페이지</a> 를 방문하여 자세한 내용을 확인해 보시기 바랍니다.</p>
<details><summary><b>Mainnet</b></summary><p dir="auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메인넷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/i18n.js Outdated
</ul>
<p dir="auto"></p></details>

<details><summary><b>Testnet</b></summary><p dir="auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트넷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@stephenpdeos stephenpdeos self-requested a review November 8, 2023 03:20
Copy link
Member

@stephenpdeos stephenpdeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yarkinwho yarkinwho merged commit 0325385 into main Nov 8, 2023
@yarkinwho yarkinwho deleted the yarkin/walletconnect-new branch November 8, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants