Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1912 Support unresolved IDT monomers (no structure, IDT only) #1988

Merged
merged 5 commits into from
Jun 6, 2024
Merged

#1912 Support unresolved IDT monomers (no structure, IDT only) #1988

merged 5 commits into from
Jun 6, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code to support unresolved IDT monomers.
Add UT.

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@AliaksandrDziarkach
#1912 Support unresolved IDT monomers (no structure, IDT only)
7a088ba 
Fix code to support unresolved IDT monomers.
Add UT.
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Jun 6, 2024 that may be closed by this pull request
Support unresolved IDT monomers (no structure, IDT only) #1912
Closed
even1024
even1024 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@even1024 even1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK

@AliaksandrDziarkach AliaksandrDziarkach merged commit 201531c into master Jun 6, 2024
74 checks passed
@AliaksandrDziarkach AliaksandrDziarkach deleted the feature/1912-unresolved-idt-monomers branch June 6, 2024 20:29
AliaksandrDziarkach added a commit that referenced this pull request Jun 6, 2024
@AliaksandrDziarkach
#1912 Support unresolved IDT monomers (no structure, IDT only) (#1988)
408f996 
Merge from master to 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support unresolved IDT monomers (no structure, IDT only)
2 participants
@AliaksandrDziarkach @even1024