Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Target Identification] Upload target from Excel with custom columns #1117

Open
mzueva opened this issue Jan 3, 2024 · 4 comments
Open

[Target Identification] Upload target from Excel with custom columns #1117

mzueva opened this issue Jan 3, 2024 · 4 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@mzueva
Copy link
Collaborator

mzueva commented Jan 3, 2024

Background
It would be helpful to extend target object and genes included into the target.

Approach

Gene custom columns

  • Add field type to target [Default, Parasite]
  • Target table with genes shall support a arbitrary number of additional columns in addition to default columns (gene, gene id, tax id, species name, priority)
  • Server shall provide an API to get list of additional columns for a target
  • Server shall provide an API to get genes for a target with paging, sorting and filtering options for all fields

Additional features

  • Allow to start identification with genes of interest only
  • Import target from Excel (CSV)
@mzueva mzueva added the kind/enhancement New feature or request label Jan 3, 2024
rodichenko pushed a commit that referenced this issue Jan 22, 2024
* changed target form table for ui grid table

* fixed target action buttons visibility

* added target form actions control

* added target type and action control for parasite

* set target table for parasites

* added pagination, set genes table, added buttons for upload

* set add new target

* draft

* add new target to parasite

* reset table data with pagination

* added columns for table actions

* added sorting for target genes table

* added filtering

* style improvements

* set restore view

* removed inputs for parasite target

* moved target form methods to form service
rodichenko pushed a commit that referenced this issue Jan 29, 2024
* added confirm for filter

* added confirm for sorting

* grouped confirm functions
@maryvictol
Copy link
Collaborator

@AlfiyaRF

Bug:
The list of columns isn't shown in the columns selector menu at the creation of the parasite target.

Steps to reproduce:

  1. Create a Target with Parasite type.
  2. Upload genes and click Create button.
  3. Click the hamburger icon to open the columns selector menu.

Actual result: Only Show filters option is shown in the columns selector menu. The list of columns appears only after reopening the target.

@maryvictol
Copy link
Collaborator

maryvictol commented Feb 7, 2024

@mzueva

Bug:
Problems with Priority column:

  1. If uploaded file with Genes contains column Priority with at least one value (Low/High), then an attempt to create parasite Target gives the error cannot change DocValues type from NUMERIC to SORTED for field "Priority".
  2. Filter for the Priority column contains number values instead of Low/High
    image

@maryvictol
Copy link
Collaborator

@AlfiyaRF

Bug:
It's impossible to remove any gene from Genes table.

To reproduce: Open any Parasite Target >> Click Remove button for several genes >> Click Save button
Actual result: Table is refreshed after saving. All removed genes are returned to the table.

@maryvictol
Copy link
Collaborator

@okolesn

The target file with csv format isn't uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants