Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supported Cohere embedding models #132

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: supported Cohere embedding models #132

merged 2 commits into from
Jul 29, 2024

Conversation

adubovik
Copy link
Collaborator

@adubovik adubovik commented Jul 26, 2024 •
edited
Loading

Resolves #131

@adubovik adubovik self-assigned this Jul 26, 2024
@adubovik adubovik changed the title feat: supported cohere embedding models feat: supported Cohere embedding models Jul 26, 2024
@adubovik adubovik mentioned this pull request Jul 26, 2024
Closed
Base automatically changed from feat/migrate-to-latest-sdk to development July 26, 2024 16:06
@adubovik adubovik force-pushed the feat/support-cohere-embeddings branch from 8ae7d60 to 326c4a3 Compare July 26, 2024 16:09
@adubovik adubovik marked this pull request as ready for review July 26, 2024 16:09
@adubovik
Copy link
Collaborator Author

adubovik commented Jul 26, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-bedrock-pr-132.nightly-test.deltixhub.io
E2E tests status: success

roman-romanov-o
roman-romanov-o previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@roman-romanov-o roman-romanov-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments are minor, and could be done in other PRs

tests/integration_tests/test_embeddings.py Outdated Show resolved Hide resolved
aidial_adapter_bedrock/bedrock.py Outdated Show resolved Hide resolved
@roman-romanov-o roman-romanov-o self-requested a review July 29, 2024 09:02
@adubovik adubovik merged commit 7c2a1f6 into development Jul 29, 2024
6 checks passed
@adubovik adubovik deleted the feat/support-cohere-embeddings branch July 29, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-romanov-o roman-romanov-o roman-romanov-o approved these changes

Assignees

@adubovik adubovik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support embeddings models from Cohere
2 participants
@adubovik @roman-romanov-o