Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove explicit caching in workflows (#34) #35

Merged
merged 1 commit into from
Mar 4, 2024
Merged

chore: Remove explicit caching in workflows (#34) #35

merged 1 commit into from
Mar 4, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 4, 2024

Pull Request Template

Description

The PR removes explicit caching actions/caching in workflows because actions/setup-go@v4 has built-in caching. For more information, visit https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs

The cache added in the commit 77584cf.

Additionally, the PR updates the versions of the actions: setup-go to v5 and checkout to v4. It also reorders them so that checkout comes before setup-go.

For consistency with pr.yaml and release.yaml, this PR introduces env.GOLANG_VERSION.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contain one commit. I squash my commits

Screenshots (if appropriate):

Additional context

Here is the screenshot of build-and-lint job, demonstrating the use of cache following changes in this PR:

image

@alexandear alexandear changed the title chore: The action setup-go caches by default chore: Remove explicit caching in workflows Mar 4, 2024
@alexandear alexandear changed the title chore: Remove explicit caching in workflows chore: Remove explicit caching in workflows (#34) Mar 4, 2024
@SergK SergK added the enhancement New feature or request label Mar 4, 2024
@SergK SergK self-requested a review March 4, 2024 17:51
@SergK SergK merged commit 8d291b0 into epam:master Mar 4, 2024
10 checks passed
@SergK
Copy link
Member

SergK commented Mar 4, 2024

hi @alexandear thank you for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants