Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added single end read handling to xenome #134

Merged
merged 2 commits into from
May 12, 2020
Merged

Added single end read handling to xenome #134

merged 2 commits into from
May 12, 2020

Conversation

syansanofi
Copy link
Collaborator

Propose to add single end xenome functionality. Working version. Please free to add/change en mass.

@kamyshova
Copy link
Collaborator

@syansanofi Hi, Shu. Ok, we'll review and make any modifications if needed.

@codecov-io
Copy link

Codecov Report

Merging #134 into develop will decrease coverage by 0.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #134      +/-   ##
=============================================
- Coverage      95.16%   95.15%   -0.02%     
- Complexity       611      621      +10     
=============================================
  Files            115      115              
  Lines           3186     3199      +13     
  Branches         156      167      +11     
=============================================
+ Hits            3032     3044      +12     
  Misses            83       83              
- Partials          71       72       +1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/epam/fonda/tools/impl/Xenome.java 98.36% <96.15%> (-1.64%) 14.00 <0.00> (+10.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d311524...78ab1d8. Read the comment docs.

@kamyshova
Copy link
Collaborator

@syansanofi Shu, I've added some changes to the branch. Could you check them, please? After your approval, I'll merge this to the develop branch.

@syansanofi
Copy link
Collaborator Author

syansanofi commented May 11, 2020

Looks correct. (Sorry but I don't see option to merge) I will reopen this. Thanks!

@syansanofi syansanofi closed this May 11, 2020
@syansanofi syansanofi reopened this May 11, 2020
@syansanofi syansanofi requested review from ekazachkova and mrfirelord and removed request for mrfirelord and ekazachkova May 11, 2020 19:05
@kamyshova kamyshova merged commit 070b584 into develop May 12, 2020
@kamyshova kamyshova deleted the xenome_single branch May 12, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants