Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and Size Tails of a multi-tail arrow #5107

Closed
yauhen-karmyzau opened this issue Jul 15, 2024 · 3 comments
Closed

Move and Size Tails of a multi-tail arrow #5107

yauhen-karmyzau opened this issue Jul 15, 2024 · 3 comments
Assignees
Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Test Cases Written Test cases has been written for that issue

Comments

@yauhen-karmyzau
Copy link
Collaborator

yauhen-karmyzau commented Jul 15, 2024

As a User, I want to move and resize the tails of a multi-tail arrow so that I can accurately represent the reactants in my synthesis tree.

Acceptance Criteria:

  1. When the user is hovering on the left corner of one of the tails, clicking and dragging to the left or right changes the widths of all tails.
    1.1. During and after moving, the whole arrow should be highlighted/selected.
    1.2. Dragging to the left is not limited.
    1.3. Dragging to the right is limited to [minimum tail length>=radius of the corner curve]

  2. When the user is hovering over the center of a tail (not the left corner), clicking and dragging up and down changes the position of the tail, and (if applicable) changes the length of the spine and the corner curvature.
    2.1. During and after moving, the whole arrow should be highlighted.
    2.2. Behaviour for the upper tail is covered bellow.
    2.2.1. The upper tail can be moved up with no limitation.
    2.2.1.1. The spine is adjusted accordingly.
    2.2.2. The upper tail can be moved down until one radius of the corner curve above the head or another tail
    (whichever comes first).
    (Image for better understanding)
    image
    2.2.2.1. The spine is adjusted accordingly.
    2.2.2.2. Any dragging bellow this point results in no movement.
    2.3. The behavior for the lower tail is identical to the behavior for the upper tail, just with reversed directions.
    2.4. The middle tail(s) can be moved anywhere along the spine with a radius of the corner curve as the limitation on both sides.
    2.4.1. If the user drags the tail closer than one radius of the corner curve to another tail, after releasing the cursor, the tail position is automatically adjusted to the closest position to where the user dragged the tail, that is at least one radius of the corner curve away form other tails.
    (Image for better understanding)
    image

  3. Pointer must represent possible actions.
    Image

Image

Selection and hover highlighting of the whole Multi-Tailed Arrow is out of scope for this task - it will be implemented here - #5057

@yauhen-karmyzau yauhen-karmyzau added MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool labels Jul 15, 2024
@yauhen-karmyzau yauhen-karmyzau added this to the Ketcher 2.25.0-rc.1 milestone Jul 16, 2024
daniil-sloboda added a commit that referenced this issue Aug 23, 2024
daniil-sloboda added a commit that referenced this issue Aug 23, 2024
@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Aug 23, 2024

During exploratory preview testing on the nightly environment (5107-move-size-head-tails) some issues are found, need to be fixed:

  • Can't remove middle tail;
  • Can move tail to any place on spine if selection tool is used;
  • When moving down the top tail, it stops 0.35 before head but should stop 0.15
  • Multiple issues with rounding of coordinates for tails, issues for cases when there are no free spaces for moving tail;
  • Can't put tail to 0.35 before the bottom tail, it returns back;
  • Console issue when image is added to Canvas;

daniil-sloboda added a commit that referenced this issue Aug 23, 2024
@ivanmaslow ivanmaslow added the Test Cases Written Test cases has been written for that issue label Aug 27, 2024
daniil-sloboda added a commit that referenced this issue Aug 28, 2024
daniil-sloboda added a commit that referenced this issue Aug 28, 2024
daniil-sloboda added a commit that referenced this issue Aug 28, 2024
@ivanmaslow
Copy link
Collaborator

Points above are fixed and verified on Nightly environment (5057-hover-selection):

  • Middle tail can be removed:
    image
  • Tails can be moved when the selection tool is used:
    image
  • When moving down the top tail, it stops 0.15 before head:
    image
  • Issues for cases when there are no free spaces for moving tail related to rounding - fixed, no errors are in console;
  • Tail can be put to 0.35 before the bottom tail:
    image
  • Console issue when image is added to Canvas - fixed, no error are in console;

daniil-sloboda added a commit that referenced this issue Aug 29, 2024
daniil-sloboda added a commit that referenced this issue Aug 29, 2024
daniil-sloboda added a commit that referenced this issue Aug 29, 2024
daniil-sloboda added a commit that referenced this issue Aug 30, 2024
daniil-sloboda added a commit that referenced this issue Aug 30, 2024
daniil-sloboda added a commit that referenced this issue Aug 30, 2024
rrodionov91 pushed a commit that referenced this issue Sep 2, 2024
@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 10, 2024

Exploratory testing is completed on the RC Remote environment:

  • Ketcher [Version 2.25.0-rc.1] Build at 2024-09-03; 15:37:29
  • Indigo Version 1.24.0-rc.1.0-gb8f099851-x86_64-linux-gnu-11.2.1
  • Windows 11 Enterprise
  • Chrome Version 128.0.6613.120 (Official Build) (64-bit)

The following checks were performed, and tests are updated:

  • The top/bottom tails of Multi-Tailed Arrow added from KET file or added by Tool can be moved down/up, but not closer than 0.15 from head arrow or according to minimal spine length = 0.5:
    image
  • The size of top/bottom tails of Multi-Tailed Arrow added from KET file or added by Tool can be increased to left and decreased to right (0.4 from spine):
    image
  • Middle tails of Multi-Tailed Arrow added from KET file or added by Tool can be moved down/up but not closer than 0.35 from top/bottom or another tails:
    image
  • The size of middle tails of Multi-Tailed Arrow added from KET file or added by Tool can be increased to left and decreased to right (0.4 from spine):
    image
  • Checks above were performed for one/several Multi-Tailed Arrows on Canvas with/without chemical elements;
  • If tail is moved to any other tail or to distance less that 0.35 of another tails it will be placed to the nearest available place
  • Undo/Redo actions for moving/resizing of tails arrow of Multi-Tailed Arrows added by Tool or from KET file;
  • Copy-Paste and Cut-Paste actions for Multi-Tailed Arrows added by Tool or from KET file after moving/resizing of tails;
  • Movement of Multi-Tailed Arrows added by Tool or from KET file after moving/resizing of tails;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

No branches or pull requests

3 participants