Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance update, part 1 #421

Merged
merged 6 commits into from
Sep 12, 2022
Merged

Maintenance update, part 1 #421

merged 6 commits into from
Sep 12, 2022

Conversation

paulsmirnov
Copy link
Member

@paulsmirnov paulsmirnov commented Sep 12, 2022

Description

Time flies by, teams come and go, issues multiply and hide each other, dependencies become old and outdated, and security vulnerabilities appear.

  • Normalize all the line endings
  • Fix pending lint issues
  • Update caniuse-lite for browserlist
  • Enable yarn upgrade-interactive
  • Force security updates for nested dependencies

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation / The changes do not need docs update.

@paulsmirnov
Copy link
Member Author

paulsmirnov commented Sep 12, 2022

GitHub actions still use Node v14 which is in maintenance mode that will end soon.
The active LTS is Node v16, and in a month it will be replaced by v18.

schedule

o.hasOwnProperty() is marked as unsafe by ESLint; it can be replaced with Object.prototype.hasOwnProperty.call() or a shorter Object.hasOwn(). The latter is not supported by Node v14. It is supported by modern browsers: https://caniuse.com/?search=hasOwn

`Object.hasOwn()` is supported in Node.js starting with 16.9.0.
`Object.prototype.hasOwnProperty.call()` could be a workaround if we
wanted to maintain compatibility with Node v14 that will end soon.
Perhaps, we don't. We'll consider v18 in a month.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant