Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD GitHub Actions added #492

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Conversation

AlinaFirsova
Copy link
Collaborator

@AlinaFirsova AlinaFirsova commented Oct 12, 2023

Description

GitHub Actions for Miew

Sonar-scanner was temporary removed:

 - name: After success steps
   run: |
     sonar-scanner
     npm run coveralls
     if [ "${{ github.event_name }}" != "pull_request" ]; then
       /tmp/cc-test-reporter after-build --exit-code $?
     fi

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • The changes do not need test updates.
  • The changes do not need doc updates.

Copy link
Collaborator

@NataliaDSmirnova NataliaDSmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks 👏
It's a very important improvement!

Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks! 🥳
Please consider making changes to address my comments.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@paulsmirnov paulsmirnov linked an issue Nov 9, 2023 that may be closed by this pull request
@paulsmirnov paulsmirnov merged commit 90faed1 into main Nov 9, 2023
2 checks passed
@paulsmirnov paulsmirnov deleted the feature/ci-cd-github-actions-added branch November 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GithubActions for CI/CD
4 participants