Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1CRN loading from Gallery #531

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix 1CRN loading from Gallery #531

merged 2 commits into from
Mar 7, 2024

Conversation

NataliaDSmirnova
Copy link
Collaborator

#515

Description

  • Now we load all molecules presented in Gallery from web (unified approach)

Type of changes

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix/feature works OR The changes do not require updated tests.
  • I have added the necessary documentation OR The changes do not require updated docs.

@NataliaDSmirnova NataliaDSmirnova linked an issue Mar 7, 2024 that may be closed by this pull request
HTTP 404 while fetching http://localhost:8080/data/1CRN.pdb #515
Closed
@coveralls
Copy link

Coverage Status

coverage: 25.047%. remained the same
when pulling c67acbf on 515-http-404-while-fetching-httplocalhost8080data1crnpdb
into 442b948 on main.

paulsmirnov
paulsmirnov approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that should improve consistency! It will match the other items in the gallery. Thanks!

@NataliaDSmirnova NataliaDSmirnova merged commit 8503b1d into main Mar 7, 2024
4 checks passed
@NataliaDSmirnova NataliaDSmirnova deleted the 515-http-404-while-fetching-httplocalhost8080data1crnpdb branch March 7, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulsmirnov paulsmirnov paulsmirnov approved these changes

@AlinaFirsova AlinaFirsova Awaiting requested review from AlinaFirsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP 404 while fetching http://localhost:8080/data/1CRN.pdb
3 participants
@NataliaDSmirnova @coveralls @paulsmirnov