Workflow level inputs/outputs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniilsavchuk
approved these changes
May 26, 2017
|
@voidest , could you please rebase this PR onto #30 ? |
voidest
force-pushed
the
feature/workflow-inputs
branch
from
fc7b96e
to
02bba36
Compare
|
@sidoruka, done. I've also added methods to enable/disable ports on a whole diagram. |
|
@voidest , thanks a lot. |
|
@sidoruka Yes of course! I will inform you as soon I'll be able to do that |
added 9 commits
May 29, 2017 13:33
Apparently, jointjs handles group addition of new cells to graph in more efficient way than adding on-by-one. Therefore, update mechanism was changed in order to speed up update.
Often user does not want to observe all links of a diagram and in case of huge workflows, the number of links may bring more chaos than usefulness/ Thus, each port now can be visually disabled by shft+click. When disabled, it appears transparent and all connected links are hidden.
sidoruka
force-pushed
the
feature/workflow-inputs
branch
from
af3d6fa
to
df524d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General idea
At the moment, workflow is not shown on the diagram, which makes user unable to manage links between worklow and its children. This feature was requested in #10. Unfortunaly, on comples diagarams workflow has too many links wis children and they occupy too much visual space and hinder visual perception. Therefore, port toggling was implemented. By shift-clicking on port one can enable/disable it. Workflow ports are disabled by default.
Changes
Added visual port toggling mechanism, added VisualWorkflow entity and added workflow to the diagram.