Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling of AnyCode #39

Closed
3 tasks done
LPTK opened this issue Dec 12, 2017 · 0 comments
Closed
3 tasks done

Remove special handling of AnyCode #39

LPTK opened this issue Dec 12, 2017 · 0 comments

Comments

@LPTK
Copy link
Member

LPTK commented Dec 12, 2017

There is no reason to handle AnyCode specially as it is done now (reminiscence of the experimental separation between simple and contextual QQs). It is in fact a soundness hole (see: val x: AnyCode[Int] = code"(?str:String).length"; code"$x".run).

We should direct users to use OpenCode in all cases where AnyCode is used today, and remove special handling in QuasiMacros, QuasiEmbedder, and related $Code functions in QuasiBase.

  • deprecate insertion of AnyCode expressions, which is unsafe
  • change doc to mention OpenCode instead of AnyCode
  • remove special support from the implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant