Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't reexport tfjs/discojs-core #640

Merged
merged 2 commits into from
Feb 29, 2024
Merged

don't reexport tfjs/discojs-core #640

merged 2 commits into from
Feb 29, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Feb 28, 2024

implementation of #638

@tharvik tharvik self-assigned this Feb 28, 2024
@JulienVig
Copy link
Collaborator

JulienVig commented Feb 28, 2024

Very nice!!
Once the PR #636 is merged can you remove the doc information on importing different tfjs versions ?
It's in docs/CONTRIBUTING.md, Section #discojs-core-discojs-node-and-discojs-web:

Note that, if you end up making calls to the Tensorflow.js API, you must import it from the root index. This is to ensure the right version of TF.js is loaded (depending on the compilation dist/), and only once. The only exception occurs in unit tests, which should import TF.js from the (local) @epfml/discojs-node, since those run on Node.js.

@tharvik tharvik changed the base branch from develop to 635-update-doc-julien February 28, 2024 16:31
Base automatically changed from 635-update-doc-julien to develop February 28, 2024 17:30
@tharvik tharvik marked this pull request as ready for review February 28, 2024 23:05
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say, everything seems to work well and everything seems much better

@tharvik tharvik merged commit f2bf9e2 into develop Feb 29, 2024
20 checks passed
@tharvik tharvik deleted the 638-no-reexport-tharvik branch February 29, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants