-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email templates #1023
Merged
Merged
Email templates #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrindt
added
[C] enhancement
Changes to an existing feature making it better
[C] design/ui
Enhancement of existing views
labels
Aug 7, 2023
felixrindt
force-pushed
the
email-templates
branch
from
August 7, 2023 18:19
cf1b743
to
cfe503e
Compare
felixrindt
commented
Aug 9, 2023
felixrindt
force-pushed
the
email-templates
branch
2 times, most recently
from
August 9, 2023 17:20
5cb6621
to
68c2ac6
Compare
jeriox
approved these changes
Aug 9, 2023
felixrindt
force-pushed
the
email-templates
branch
from
August 9, 2023 21:31
68c2ac6
to
7272ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C] design/ui
Enhancement of existing views
[C] enhancement
Changes to an existing feature making it better
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #372
related to #989
apperently building email html is terribly complex
Approach:
get_url
got refactored toget_actions
(label+url), which are rendered in plaintext and html. We could later use them as push notification actions.Developing
I released the test plugin in a new version to include the view you see below.