Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email templates #1023

Merged
merged 15 commits into from Aug 9, 2023
Merged

Email templates #1023

merged 15 commits into from Aug 9, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Aug 7, 2023

closes #372
related to #989

apperently building email html is terribly complex

  • validate how embedded images get deliverd to actual mailboxes. Our provider marked versions with embedded svg as junk.
  • build a "mail was read" mechanism (alternativly only "action was clicked") --> moved to do with Notification Framework Improvements #989
  • clickable org name
  • try out centering action buttons and header
  • link to disable all email notifications
  • Remove alt Text from top logo

Approach:

  • Notifications provide a subject and body
  • Plaintext is rendered just as html: with a template
  • get_url got refactored to get_actions (label+url), which are rendered in plaintext and html. We could later use them as push notification actions.

Developing

I released the test plugin in a new version to include the view you see below.

@felixrindt
Copy link
Member Author

image

@coveralls
Copy link

coveralls commented Aug 7, 2023

Coverage Status

coverage: 88.896% (+0.1%) from 88.766% when pulling 7272ee3 on email-templates into 7cee58c on main.

@felixrindt felixrindt added [C] enhancement Changes to an existing feature making it better [C] design/ui Enhancement of existing views labels Aug 7, 2023
@felixrindt felixrindt added this to the Dennis milestone Aug 7, 2023
@felixrindt felixrindt requested a review from jeriox August 9, 2023 16:47
@felixrindt felixrindt force-pushed the email-templates branch 2 times, most recently from 5cb6621 to 68c2ac6 Compare August 9, 2023 17:20
@felixrindt felixrindt enabled auto-merge (rebase) August 9, 2023 21:31
@felixrindt felixrindt merged commit 0752faa into main Aug 9, 2023
17 checks passed
@felixrindt felixrindt deleted the email-templates branch August 9, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] design/ui Enhancement of existing views [C] enhancement Changes to an existing feature making it better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base email template with basic design
3 participants