Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section based signup method #242

Merged
merged 8 commits into from
Jan 16, 2021
Merged

Add section based signup method #242

merged 8 commits into from
Jan 16, 2021

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Jan 9, 2021

Already fixes #11 and fixes #12 and also fixes #13.

@felixrindt felixrindt marked this pull request as ready for review January 10, 2021 22:18
@coveralls
Copy link

coveralls commented Jan 10, 2021

Coverage Status

Coverage increased (+2.7%) to 76.773% when pulling d079c4b on section-based-signup into 3a7384a on main.

@jeriox
Copy link
Contributor

jeriox commented Jan 10, 2021

image
If the user is not qualified for any sections, the signup button is disabled as expected. When accessing the signup action view directly via URL, one is presented with the following. Pressing "anfrage" loops back to the same page.

@jeriox
Copy link
Contributor

jeriox commented Jan 10, 2021

image
there are no error messages when the planner does not select a section and tries to save

@jeriox
Copy link
Contributor

jeriox commented Jan 10, 2021

image
If the user is not qualified for any sections, the signup button is disabled as expected. When accessing the signup action view directly via URL, one is presented with the following. Pressing "anfrage" loops back to the same page.

same thing applies for visiting the page while already being signed up. one can select a section and request, then a error message appears that one is already signed up

@jeriox
Copy link
Contributor

jeriox commented Jan 10, 2021

This is really amazing! Only small detail that is missing IMO:
the user cannot see what sections are available prior to clicking the request button and being redirected.
three options:

  • we do nothing about that for now
  • the list of sections is rendered additionally (e.g. as part of the key-value pairs of the shift configuration)
  • we render a list of sections where each section contains the users that have been confirmed for it and its properties (how many people are needed) for the shift state part of the shift box.

I think that option 3 is the way to go for the long term, would be fine with 1 or 2 for now

Copy link
Contributor

@jeriox jeriox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also have a look at the comments outside of the review :)

ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
ephios/plugins/basesignup/signup/section_based.py Outdated Show resolved Hide resolved
@jeriox
Copy link
Contributor

jeriox commented Jan 10, 2021

Scenario: A participation has been confirmed (and therefore a section has been selected) and the user declines the participation afterwards. Once the user requests a participation again the request is displayed with the section he once had even if users are not allowed to pick a section.

@jeriox
Copy link
Contributor

jeriox commented Jan 12, 2021

@felixrindt the user preference gets set to null once the participation is confirmed

@felixrindt felixrindt force-pushed the section-based-signup branch 2 times, most recently from 6ba9973 to 266b49f Compare January 15, 2021 21:08
tests/conftest.py Outdated Show resolved Hide resolved
tests/plugins/basesignup/test_sectionbased_signup.py Outdated Show resolved Hide resolved
@felixrindt felixrindt merged commit 8361c08 into main Jan 16, 2021
@felixrindt felixrindt deleted the section-based-signup branch January 16, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants