-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section based signup method #242
Conversation
15b1cd3
to
4ba00c3
Compare
4ba00c3
to
d6d29cf
Compare
This is really amazing! Only small detail that is missing IMO:
I think that option 3 is the way to go for the long term, would be fine with 1 or 2 for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also have a look at the comments outside of the review :)
Scenario: A participation has been confirmed (and therefore a section has been selected) and the user declines the participation afterwards. Once the user requests a participation again the request is displayed with the section he once had even if users are not allowed to pick a section. |
ephios/plugins/basesignup/templates/basesignup/requestconfirm/disposition.html
Outdated
Show resolved
Hide resolved
5d32fa0
to
3048f6c
Compare
@felixrindt the user preference gets set to null once the participation is confirmed |
6ba9973
to
266b49f
Compare
266b49f
to
d079c4b
Compare
Already fixes #11 and fixes #12 and also fixes #13.