Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n housekeeping #999

Merged
merged 9 commits into from
Jul 16, 2023
Merged

I18n housekeeping #999

merged 9 commits into from
Jul 16, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Jul 13, 2023 •
edited
Loading

Oh boy, I didn't know you had to run makemessages with the djangojs domain?!

This I think for the most part fixes #830

@felixrindt felixrindt changed the title Fix js translation Establish js translation Jul 13, 2023
@felixrindt felixrindt force-pushed the fix-js-translation branch 2 times, most recently from 90e825f to 0dd024d Compare July 13, 2023 17:21
@coveralls
Copy link

coveralls commented Jul 13, 2023 •
edited
Loading

Coverage Status

coverage: 88.107% (+0.03%) from 88.077% when pulling d038b74 on fix-js-translation into 01f46d1 on main.

@felixrindt felixrindt changed the title Establish js translation I18n housekeeping Jul 13, 2023
jeriox
jeriox reviewed Jul 13, 2023
View reviewed changes
ephios/core/signup/participants.py Show resolved Hide resolved
ephios/templates/base.html Show resolved Hide resolved
ephios/urls.py Show resolved Hide resolved
@felixrindt felixrindt requested a review from jeriox July 14, 2023 08:32
@felixrindt
translate webpush
be72caf
@felixrindt
remove js i18n catalog view as we use static-i18n
c518b9b
@felixrindt
move statici18n back to compress
d038b74 
as 500.html is not using the base template we can revert the
extraction from 2021
@felixrindt felixrindt added [C] documentation Improvements or additions to documentation [C] enhancement Changes to an existing feature making it better [C] translation missing or wrong translations labels Jul 14, 2023
@felixrindt felixrindt merged commit 26d8ae1 into main Jul 16, 2023
16 checks passed
@felixrindt felixrindt deleted the fix-js-translation branch July 16, 2023 10:23
@jeriox jeriox mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

@gritfessel gritfessel Awaiting requested review from gritfessel

Assignees
No one assigned
Labels
[C] documentation Improvements or additions to documentation [C] enhancement Changes to an existing feature making it better [C] translation missing or wrong translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for untranslated strings
3 participants
@felixrindt @coveralls @jeriox