Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curse changed their directory structure - again #75

Open
ilu33 opened this issue Jun 27, 2019 · 12 comments
Open

Curse changed their directory structure - again #75

ilu33 opened this issue Jun 27, 2019 · 12 comments

Comments

@ilu33
Copy link

ilu33 commented Jun 27, 2019

... Updates don't work anmore (404). They add a (random?) number at the end of the URL.

@ilu33 ilu33 changed the title Curse changed their directory structure Curse changed their directory structure - again Jun 27, 2019
@Nuadh
Copy link

Nuadh commented Jul 4, 2019

Probably not a good idea, but I've made a (temporary) replacement in perl. Just so I can update my addons without running windows:)
Tbh, I would rather use lcurse, but, hey..

https://git.smokepit.net/Nuadh/pcurse

Ps.: I'm sorry I advertise other software here, It's probably not nice.

@fbesser
Copy link

fbesser commented Jul 5, 2019

Probably not a good idea, but I've made a (temporary) replacement in perl. Just so I can update my addons without running windows:)
Tbh, I would rather use lcurse, but, hey..

thank you for your work, but unfortunately it's not working. I get Found Clique(v80000-1.0.0)Could not find product id for Clique for every Addon

@Nuadh
Copy link

Nuadh commented Jul 5, 2019

Could you send me your ~/.lcurse/addons.json, /.pcurse/config.json and ~/.pcurse/addons.json . I'll try to find out what makes it misbehave:)

@fbesser
Copy link

fbesser commented Jul 5, 2019

Could you send me your ~/.lcurse/addons.json, /.pcurse/config.json and ~/.pcurse/addons.json . I'll try to find out what makes it misbehave:)

here you go

@Nuadh
Copy link

Nuadh commented Jul 5, 2019

My bad, expecting a http Uri, not a HTTPS one:) new version up, please try again:)

@fbesser
Copy link

fbesser commented Jul 5, 2019

My bad, expecting a http Uri, not a HTTPS one:) new version up, please try again:)

Works great thank you

@ilu33
Copy link
Author

ilu33 commented Jul 7, 2019

@mboquien has fixed his lcurse fork, until @ephraim pulls in the changes just use his version.

@Philmore971
Copy link
Contributor

Hi all.
I made some changes to waitdlg.py
I also used the latest proposed code elements on the main branch
Catalogue and addon updates are functional
I downloaded my modified version on my fork
https://github.com/Philmore971/lcurse
Do not use the file directly, there are translations Fr inside the code
Sometimes the catalogue update stops before the end (98% 99%)
I don’t have an answer
Test my version please

@ilu33
Copy link
Author

ilu33 commented Aug 11, 2019

Curse changes again: Now they are providing versions for wow classic under the same project - see BigWigs, Capping, DBM and probably others too. If I enter https://www.curseforge.com/wow//download in the browser the correct non-classic version gets selected. But lcurse seems to check for the newest version and enters that specific id which might be the classic version, depending on what was most recently updated. At the moment most of those addons have a file name that ends on "-classic". But that's not a given so checking the game version would be necessary.

Any idea how to adapt the code, @mboquien, perhaps?

@mboquien
Copy link
Contributor

@ilu33 My subscription has lapsed and I will likely not go back for at least a couple of month. If nobody has had a look by then, I will dig into it.

@Philmore971
Copy link
Contributor

we will only have to process the download corresponding to the correct version of Wow. Actually, wow-classic is installed in another directory. Lcurse does not handle several versions of Wow. For the moment, I had no problem with the versions. Wow 8.2 seems to be the default version when downloading ... to check.

ephraim pushed a commit that referenced this issue Aug 21, 2019
* Fixes addon updates (#75)

* Fix the fix (the span is now within a div and the return value was cleaned up accidentally before the commit).
@fbesser
Copy link

fbesser commented Aug 21, 2019

actually it is a problem, it gets the first Release from the list and if the classic version is the last release it installs the classic version. Ran into this with a few addons, like Bigwigs and Details!. Problem is every Addon names their releases different most addons add -classic to the end of the version, easy to filter out with

              while True:
                    print(lis[versionIdx].td.next_sibling.next_sibling.a.string)
                    isOk= beta or lis[versionIdx].td.div.span.string=='R' and not "classic" in lis[versionIdx].td.next_sibling.next_sibling.a.string
                    if isOk:
                        break
                    versionIdx=versionIdx+1

But Details! i.e. just uses total different version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants