Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Folder arent removed when addon is removed from lcurse #9

Closed
ephraim opened this issue May 20, 2015 · 4 comments
Closed

Addon Folder arent removed when addon is removed from lcurse #9

ephraim opened this issue May 20, 2015 · 4 comments

Comments

@ephraim
Copy link
Owner

ephraim commented May 20, 2015

A removed addon of lcurse is still available in wow.

The remove dlg should have the option that lcurse should try to remove it from wow too.

@fosspill
Copy link
Contributor

Hmm, any hints as to how we could go about fixing this? I'm very interested in trying! :)

@sunaurus
Copy link
Contributor

Should be very simple: https://docs.python.org/3/library/shutil.html#shutil.rmtree

But you should be careful - make sure that it's impossible for a wrong path to end up as an argument (don't want users to delete their home directories)

@fosspill
Copy link
Contributor

Fair enough, I was more thinking about how we should include it in the code (what file would it belong in, for instance)

@sunaurus
Copy link
Contributor

I think you could just expand the existing removeAddon method here: https://github.com/ephraim/lcurse/blob/master/modules/application.py#L344

shinnova added a commit to shinnova/lcurse that referenced this issue Aug 19, 2016
ephraim added a commit that referenced this issue Aug 20, 2016
Fix for #9. Able to properly remove addons
@ephraim ephraim closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants