-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Folder arent removed when addon is removed from lcurse #9
Comments
Hmm, any hints as to how we could go about fixing this? I'm very interested in trying! :) |
Should be very simple: https://docs.python.org/3/library/shutil.html#shutil.rmtree But you should be careful - make sure that it's impossible for a wrong path to end up as an argument (don't want users to delete their home directories) |
Fair enough, I was more thinking about how we should include it in the code (what file would it belong in, for instance) |
I think you could just expand the existing removeAddon method here: https://github.com/ephraim/lcurse/blob/master/modules/application.py#L344 |
Fix for #9. Able to properly remove addons
A removed addon of lcurse is still available in wow.
The remove dlg should have the option that lcurse should try to remove it from wow too.
The text was updated successfully, but these errors were encountered: