Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go download host #107

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Update go download host #107

merged 1 commit into from
Jan 27, 2023

Conversation

spothound
Copy link
Contributor

The go download host has changed, causing a 301 redirect response which generates an error in the go installation. This commit updates the host in the HTTPS request to avoid such error, more info in #105

Landing a Pull Request (PR)

Long-form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123)
  • Code is in its branch
  • Branch name is related to the PR contents
  • PR targets master

Static analysis checks

  • All python files are formatted using black
  • All flake8 checks pass
  • All existing tests pass

Documentation

  • Documentation about your PR is included in docs/ and the README, as appropriate

Additional Tests

  • New code is unit tested
  • New tests pass

The go download host has changed, causing a 301 redirect response which generates an error in the go installation. This commit updates the host in the HTTPS request to avoid such error, more info in epi052#105
@spothound
Copy link
Contributor Author

Without the fix:
image
With the fix:
image

@epi052
Copy link
Owner

epi052 commented Jan 27, 2023

thanks again, sorry for the delay!

@epi052 epi052 merged commit 4930f40 into epi052:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants