Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release script rework #2035

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

asvae
Copy link
Member

@asvae asvae commented Jul 1, 2022

closes #2008

Did a 180 with approach. Before it took cli params. Right now you just use yarn release command and it guides you through the process.

We'd probably still need cli params for CI, but that would come later.

image

@asvae asvae force-pushed the feat/release-script-rework branch 7 times, most recently from 4ab1552 to fad2e9b Compare July 1, 2022 13:10
@asvae asvae force-pushed the feat/release-script-rework branch 3 times, most recently from 014503f to a944798 Compare July 1, 2022 13:38
@asvae asvae marked this pull request as ready for review July 1, 2022 13:46
@asvae asvae force-pushed the feat/release-script-rework branch from a944798 to 1b436b8 Compare July 1, 2022 13:52
@asvae asvae force-pushed the feat/release-script-rework branch from 1b436b8 to 3daaab7 Compare July 1, 2022 13:54
type: 'confirm',
default: false,
when: () => new Date().getHours() > 20 && ['large', 'tiny'].includes(releaseType),
message: 'It\'s too late already, sure you\'re up for release at this time?',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/ui/package.json Show resolved Hide resolved
@asvae asvae merged commit 99afc40 into epicmaxco:develop Jul 1, 2022
@asvae asvae deleted the feat/release-script-rework branch July 1, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release script issues
5 participants