Add configurable burst filter time #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-ess
reviewed
Feb 26, 2024
anjohnson
requested changes
May 28, 2024
henrique-silva
force-pushed
the
configurable-burst-time
branch
from
2ac2e42
to
cca9515
Compare
simon-ess
reviewed
Jul 17, 2024
anjohnson
reviewed
Jul 17, 2024
Parameter can be specified on caPutLogInit, caPutLogReconf or independently during runtime by caPutLogBurstTimeout()
simon-ess
force-pushed
the
configurable-burst-time
branch
3 times, most recently
from
1e0d14d
to
98b12b5
Compare
This seems to be a bit awkward to get to compile for older c++ versions; for c++11, you can use ```c static constexpr double default_burst_timeout = 5.0; ``` but for older c++ (with no `constexpr`) this is not valid; moreover, both of ```c const double default_burst_timeout = 5.0; static const double default_burst_timeout = 5.0; ``` fail for different reasons. Given that this timeout is only used in one place this seems like the simplest fix.
simon-ess
force-pushed
the
configurable-burst-time
branch
from
98b12b5
to
266341f
Compare
|
@anjohnson All of the issues should be addressed. I ended up directly assigning the const double default_burst_timeout = 5.0;
static const double default_burst_timeout = 5.0;
static constexpr double default_burst_timeout = 5.0;all fail in different cases. Who knew floats were such an issue? 🙃 |
|
One more request (sorry!); please document the new iocsh commands & arguments here and add a release note entry mentioning the changes. If this PR hasn't been rebased recently you'll want to do that first, I added release notes for the other recent changes last week. |
|
Documentation and release notes updated. |
anjohnson
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to configure the burst filter timeout in runtime, thus allowing users to match the burst filter to their application needs.
Introduces one new function for each logger implementation:
caPutLogSetBurstTimeout(<timeout>)caPutJsonLogSetBurstTimeout(<timeout>)This parameter can also be passed in the initialization or reconfiguration functions:
caPutLogInit(<address>[:port], <interest level>, <timeout>)caPutLogReconf(<interest level>, <timeout>)caPutJsonLogInit(<address>[:port], <interest level>, <timeout>)caPutJsonLogReconf(<interest level>, <timeout>)