Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCS2CreateAxis and Cal/Ref/MCL Ref readback #8

Merged
merged 10 commits into from
Apr 13, 2023

Conversation

Huijuan-Xu
Copy link

Add MCS2CreateAxis and Cal/Ref/MCL frequency readback

@kmpeters kmpeters self-requested a review February 24, 2021 17:38
@kmpeters
Copy link
Contributor

Why was the MCS2CreateAxis function added? No additional information is being passed to driver though it, but everyone who uses the MCS2 support would need to modify their IOC's config to add MCS2CreateAxis calls for every axis.

@Huijuan-Xu
Copy link
Author

Huijuan-Xu commented Feb 24, 2021 via email

@kmpeters
Copy link
Contributor

@MarkRivers, do you have thoughts on how motor drivers should handle unused channels between used channels? I can't think of any that handle it gracefully.

@MarkRivers
Copy link
Contributor

One option would be to add an UnusedMask argument to the constructor. It would be a bit mask where 1 means an axis is not used. If it were added as a final argument then startup scripts would not need to be modified because it would default to 0, and that means there are no unused axes.

For example, for an 8 axis controller UnusedMask = 0x30 means axes 4 and 5 are unused, 0-3, 6, and 7 are used.

@Huijuan-Xu
Copy link
Author

unused mask bit is added as advised

@kmpeters kmpeters merged commit a023c9f into epics-motor:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants