Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved copy-editing #138

Merged
merged 6 commits into from
Mar 18, 2020
Merged

Improved copy-editing #138

merged 6 commits into from
Mar 18, 2020

Conversation

lagerros
Copy link
Contributor

@lagerros lagerros commented Mar 17, 2020

Fix #139
Adding better text descriptions of the model

<hr />
<!-- Create a div where the graph will take place -->
<div id="my_dataviz" class="svg-container"></div>

<p>
The impact on [...country...] is simulated using a global, real-time database of human travel patterns.
Copy link
Contributor

@Bachibouzouk Bachibouzouk Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The impact on [...country...] is simulated using a global, real-time database of human travel patterns.
The impact on <span class="selected-country"></span> is simulated using a global, real-time database of human travel patterns.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will have to be updated via js in lines.js

Copy link
Contributor Author

@lagerros lagerros Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if/when you complete it, please refer to this issue: #139

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lagerros It looks to me like #139 is just a reference to this thread. Is that correct? It's currently assigned to me. Should I wait for this to get merged into staging or should I pull down your branch and update this PR myself?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I solved #139 there already :(

Add target = _blank to automatically open the link in a new tab
@Bachibouzouk Bachibouzouk merged commit 0694ef8 into master Mar 18, 2020
@Bachibouzouk Bachibouzouk deleted the improved-copy-edit branch March 18, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically display country name (tiny easy fix)
3 participants