Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename validate_general() #773

Closed
nikosbosse opened this issue Apr 4, 2024 · 1 comment · Fixed by #778
Closed

Rename validate_general() #773

nikosbosse opened this issue Apr 4, 2024 · 1 comment · Fixed by #778
Milestone
scoringutils-2.0

Comments

@nikosbosse
Copy link
Contributor

To make it more explicit what the function does (i.e. bundle all checks that are common to all forecast classes), we should rename the function.
This was discussed in #772.

Canidates:

  • validate_forecast_all()
  • validate_forecast_generic()
  • validate_forecast_general()
@nikosbosse nikosbosse added this to the scoringutils-2.0 milestone Apr 4, 2024
@nikosbosse nikosbosse mentioned this issue Apr 4, 2024
Merged
9 tasks
@seabbs
Copy link
Contributor

seabbs commented Apr 4, 2024

I think my preference order is .._generic > ..._general > .._all but I don't feel that strongly about it

@nikosbosse nikosbosse mentioned this issue Apr 4, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
scoringutils 2.0
Status: Done
Milestone
scoringutils-2.0
Development

Successfully merging a pull request may close this issue.

Issue #688 - Reorganise validate_forecast() epiforecasts/scoringutils
2 participants
@seabbs @nikosbosse