-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple domains #496
Comments
@jimmykarily You mentioned that CNAME would be a work around, but I'm not sure it would as the request would still have the same headers when traefik looks at it. |
True, and we may need to update/re-create application TLS certificates with additional alternative names. It may not be that simple but we should give it a try first and see what happens. |
One question that we will get is how to publish an app at the root of the domain as well. Currently we can only support subdomains |
This should be configurable on each push command and is a dependency of #594 |
Maybe something like |
Just to add some conversation that @jimmykarily and I just had around this: The first take of this can require a new push to change hostname(s). We can leave editing hostnames after deployment for a future ticket closer to GA. |
Let do this for now: The system domain defined during installation is the "default" one. "default" means that's the domain used for the epinio api and the epinio registry. The user can add more domains with some (new) command (e.g. To change the domain of an app, the user should be able to "add" a domain to the app. This should only create a new Ingress an the related certs. That new ingress should still point to the same app through the same service. Then the user can "remove" the old domain from the app making the whole process zero-downtime. When pushing an app for the first time, the user should be able to pick which domain should be used. I would defer the 3 other issues to separate tickets:
|
In order to have two apps using the same domain but a different path (#594) , the user must be able to set the domain to that of another app. That means set the full final domain, not just the domain on which the app will get a subdomain from (like it happens now). I think the solution should work like this:
@agracey is that plan ok? Do we need to have additional domains that behave like the default one? I mean additional domains which will be used to automatically create subdomain for apps. |
That looks good to me. I wouldn’t worry about additional parent domains unless someone specifically asks for it with a good enough reason.
…Sent from my iPhone
On Oct 21, 2021, at 1:49 AM, Dimitris Karakasilis ***@***.***> wrote:
In order to have two apps using the same domain but a different path (#594) , the user must be able to set the domain to that of another app. That means set the full final domain, not just the domain on which the app will get a subdomain from (like it happens now).
I think the solution should work like this:
If the user doesn't specify a domain, the app will get a subdomain on the "default" domain
If the user specifies a domain, that should be the complete one. Epinio won't will point that to the app, not a subdomain of it.
When registering domains on Epinio (as described above), those will be used as per the previous item. The only domain that gets subdomains is going to be the "default" one which is the one that was used during epinio install.
@agracey is that plan ok? Do we need to have additional domains that behave like the default one? I mean additional domains which will be used to automatically create subdomain for apps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Let's split this in 2 stories:
Let's keep this story for number 1. We will do number 2 here: #931 |
as part of this: epinio/epinio#496
as part of this: epinio/epinio#496
Accompanying PR: https://github.com/epinio/application/pull/1/files |
A user may want to use different domains for different applications. Right now, Epinio only supports one domain (the system-domain) and app routes are subdomains of that. Other PaaS (like Heroku for example), solve this by allowing the user to set a CNAME and point it to the application's subdomain. This may involve some updating of the underlying certs (additional CN values etc).
We need to investigate how multiple domains can be supported. If CNAMEs don't solve this, we probably need to "register" the domains with Epinio (like CloudFoundry does with shared and private domains).
Things to try out:
Questions to be answered:
The text was updated successfully, but these errors were encountered: